netdev - Re: [PATCH net] bonding: fix potential NULL deref in bond_update_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191009161139.24e2b49b@cakuba.netronome.com>
Date:   Wed, 9 Oct 2019 16:11:39 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot <syzkaller@...glegroups.com>,
        Mahesh Bandewar <maheshb@...gle.com>
Subject: Re: [PATCH net] bonding: fix potential NULL deref in
 bond_update_slave_arr

On Mon,  7 Oct 2019 15:43:01 -0700, Eric Dumazet wrote:
> syzbot got a NULL dereference in bond_update_slave_arr() [1],
> happening after a failure to allocate bond->slave_arr
> 
> A workqueue (bond_slave_arr_handler) is supposed to retry
> the allocation later, but if the slave is removed before
> the workqueue had a chance to complete, bond->slave_err
> can still be NULL.
> 
> [1]
> 
> [...]
> 
> Fixes: ee6377147409 ("bonding: Simplify the xmit function for modes that use xmit_hash")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Cc: Mahesh Bandewar <maheshb@...gle.com>

s/slave_err/slave_arr/

Applied, queued, thank you!