netdev - Re: [PATCH net-next] net: usb: ax88179_178a: write mac to hardware in get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Oct 2019 13:38:34 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Peter Fink <pedro@...elbox.red>, netdev@...r.kernel.org
Cc:     pfink@...ist-es.de, davem@...emloft.net
Subject: Re: [PATCH net-next] net: usb: ax88179_178a: write mac to hardware in
 get_mac_addr

Hello!

On 09.10.2019 17:15, Peter Fink wrote:

> From: Peter Fink <pfink@...ist-es.de>
> 
> When the MAC address is supplied via device tree or a random
> MAC is generated it has to be written to the asix chip in
> order to receive any data.
> 
> In the previous commit (9fb137a) this line was omitted

    It's not how you should cite the commit, here's how:

<12-digit SHA1> ("<commit-summary>")

> because it seemed to work perfectly fine without it.
> But it was simply not detected because the chip keeps the mac
> stored even beyond a reset and it was tested on a hardware
> with an integrated UPS where the asix chip was permanently
> powered on even throughout power cycles.
> 
> Signed-off-by: Peter Fink <pfink@...ist-es.de>
[...]

MBR, Sergei