netdev - Re: [PATCH bpf-next 05/10] bpf: implement accurate raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9911e078-9408-4943-e069-fae0a56423e4@fb.com>
Date:   Thu, 10 Oct 2019 03:54:45 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
CC:     Alexei Starovoitov <ast@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        "x86@...nel.org" <x86@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 05/10] bpf: implement accurate raw_tp context
 access via BTF

On 10/8/19 10:10 PM, Andrii Nakryiko wrote:
> for_each_member(i, t, member) {
>      if (moff + msize <= off)
>          continue; /* no overlap with member, yet, keep iterating */
>      if (moff >= off + size)
>          break; /* won't find anything, field is already too far */
> 
>      /* overlapping, rest of the checks */

makes sense. I'll tweak the comments and checks.