[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 9 Oct 2019 21:49:52 -0700
From: Jakub Kicinski <jakub.kicinski@...ronome.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>,
Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] net: add {READ|WRITE}_ONCE() annotations on
->rskq_accept_head
On Wed, 9 Oct 2019 14:51:20 -0700, Eric Dumazet wrote:
> reqsk_queue_empty() is called from inet_csk_listen_poll() while
> other cpus might write ->rskq_accept_head value.
>
> Use {READ|WRITE}_ONCE() to avoid compiler tricks
> and potential KCSAN splats.
>
> Fixes: fff1f3001cc5 ("tcp: add a spinlock to protect struct request_sock_queue")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
Applied, thanks!
Powered by blists - more mailing lists