netdev - Re: [PATCH net] net: annotate sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Oct 2019 21:51:39 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] net: annotate sk->sk_rcvlowat lockless reads

On Wed,  9 Oct 2019 15:32:35 -0700, Eric Dumazet wrote:
> sock_rcvlowat() or int_sk_rcvlowat() might be called without the socket
> lock for example from tcp_poll().
> 
> Use READ_ONCE() to document the fact that other cpus might change
> sk->sk_rcvlowat under us and avoid KCSAN splats.
> 
> Use WRITE_ONCE() on write sides too.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks!