netdev - Re: [PATCH] ath10k: Correct error check of dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191011115732.173FC60ADE@smtp.codeaurora.org>
Date:   Fri, 11 Oct 2019 11:57:32 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Niklas Cassel <niklas.cassel@...aro.org>,
        stable@...r.kernel.org
Subject: Re: [PATCH] ath10k: Correct error check of dma_map_single()

Bjorn Andersson <bjorn.andersson@...aro.org> wrote:

> The return value of dma_map_single() should be checked for errors using
> dma_mapping_error(), rather than testing for NULL. Correct this.
> 
> Fixes: 1807da49733e ("ath10k: wmi: add management tx by reference support over wmi")
> Cc: stable@...r.kernel.org
> Reported-by: Niklas Cassel <niklas.cassel@...aro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Did this fix any real bug? Or is this just something found during code review?

-- 
https://patchwork.kernel.org/patch/11183923/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches