netdev - Re: [PATCH net-next v2] net: usb: ax88179_178a: write mac to hardware in get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Oct 2019 20:51:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pedro@...elbox.red
Cc:     netdev@...r.kernel.org, pfink@...ist-es.de
Subject: Re: [PATCH net-next v2] net: usb: ax88179_178a: write mac to
 hardware in get_mac_addr

From: Peter Fink <pedro@...elbox.red>
Date: Thu, 10 Oct 2019 15:00:22 +0200

> From: Peter Fink <pfink@...ist-es.de>
> 
> When the MAC address is supplied via device tree or a random
> MAC is generated it has to be written to the asix chip in
> order to receive any data.
> 
> Previously in 9fb137aef34e ("net: usb: ax88179_178a: allow
> optionally getting mac address from device tree") this line was
> omitted because it seemed to work perfectly fine without it.
> 
> But it was simply not detected because the chip keeps the mac
> stored even beyond a reset and it was tested on a hardware
> with an integrated UPS where the asix chip was permanently
> powered on even throughout power cycles.
> 
> Fixes: 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree")
> Signed-off-by: Peter Fink <pfink@...ist-es.de>

Applied, thank you.