[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGnkfhwoq14__Ccen33rjorVk3rDTHfNYVnCiTpo7DwNZsakuw@mail.gmail.com>
Date: Sat, 12 Oct 2019 15:32:48 +0200
From: Matteo Croce <mcroce@...hat.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev <netdev@...r.kernel.org>, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH iproute2] testsuite: don't clobber /tmp
On Tue, Jun 25, 2019 at 4:39 PM Matteo Croce <mcroce@...hat.com> wrote:
>
> On Thu, Jun 13, 2019 at 7:15 PM Matteo Croce <mcroce@...hat.com> wrote:
> >
> > On Wed, Jun 12, 2019 at 8:20 PM Stephen Hemminger
> > <stephen@...workplumber.org> wrote:
> >
> > To me any path could work, both /tmp or in the current dir, I have no
> > preference.
> > The important thing is to remove them wherever they are, as clobbering
> > the build dir is bad as messing /tmp.
> >
> > Anyway, I double checked, and the only target which uses that
> > temporary file is 'alltests' so, if the path is ok, I think that the
> > condition "ifeq ($(MAKECMDGOALS),alltests)" is the only one which
> > fixes the issue and keeps the behaviour unaltered.
> > I did some quick tests and it works for me.
> >
> > Bye,
> > --
> > Matteo Croce
> > per aspera ad upstream
>
> Hi,
>
> any more thoughts about this patch?
>
> --
> Matteo Croce
> per aspera ad upstream
Hi,
almost forgot about this one. Should I resend it, or it was nacked?
Regards,
--
Matteo Croce
per aspera ad upstream
Powered by blists - more mailing lists