netdev - Re: [net-next v3 2/7] net: reject PTP periodic output requests with unsupported flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191012180856.GC3165@localhost>
Date:   Sat, 12 Oct 2019 11:08:56 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org,
        Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>,
        Jeffrey Kirsher <jeffrey.t.kirsher@...el.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        "David S . Miller" <davem@...emloft.net>,
        Christopher Hall <christopher.s.hall@...el.com>
Subject: Re: [net-next v3 2/7] net: reject PTP periodic output requests with
 unsupported flags

On Thu, Sep 26, 2019 at 11:11:04AM -0700, Jacob Keller wrote:
> Commit 823eb2a3c4c7 ("PTP: add support for one-shot output") introduced
> a new flag for the PTP periodic output request ioctl. This flag is not
> currently supported by any driver.
> 
> Fix all drivers which implement the periodic output request ioctl to
> explicitly reject any request with flags they do not understand. This
> ensures that the driver does not accidentally misinterpret the
> PTP_PEROUT_ONE_SHOT flag, or any new flag introduced in the future.
> 
> This is important for forward compatibility: if a new flag is
> introduced, the driver should reject requests to enable the flag until
> the driver has actually been modified to support the flag in question.
> 
> Cc: Richard Cochran <richardcochran@...il.com>
> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Christopher Hall <christopher.s.hall@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>

Reviewed-by: Richard Cochran <richardcochran@...il.com>