netdev - Re: [PATCH V2 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 13 Oct 2019 12:53:51 +0200
From:   Marek Vasut <marex@...x.de>
To:     Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        George McCollister <george.mccollister@...il.com>,
        Tristram Ha <Tristram.Ha@...rochip.com>,
        Woojung Huh <woojung.huh@...rochip.com>
Subject: Re: [PATCH V2 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

On 10/12/19 11:22 PM, Heiner Kallweit wrote:

[...]

>>> @@ -1141,13 +1174,12 @@ static struct phy_driver ksphy_driver[] = {
>>>  	.suspend	= genphy_suspend,
>>>  	.resume		= genphy_resume,
>>>  }, {
>>> -	.phy_id		= PHY_ID_KSZ8795,
>>> -	.phy_id_mask	= MICREL_PHY_ID_MASK,
>>>  	.name		= "Micrel KSZ8795",
>>>  	/* PHY_BASIC_FEATURES */
>>>  	.config_init	= kszphy_config_init,
>>>  	.config_aneg	= ksz8873mll_config_aneg,
>>>  	.read_status	= ksz8873mll_read_status,
>>> +	.match_phy_device = ksz8795_match_phy_device,
>>>  	.suspend	= genphy_suspend,
>>>  	.resume		= genphy_resume,
>>>  }, {
>>>
>>
>> Patch needs to be annotated as "net-next".
>> See https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt
>>
> Except you consider this a fix, then it would require a Fixes tag and
> should be annotated "net". The question is:
> Do KSZ87xx switches misbehave currently?

Well yes they do, otherwise I won't be sending this fix.

-- 
Best regards,
Marek Vasut