lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Oct 2019 12:58:04 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Vito Caputo <vcaputo@...garu.com>, davem@...emloft.net Cc: netdev@...r.kernel.org Subject: Re: [PATCH] net: core: skbuff: skb_checksum_setup() drop err On 10/12/19 5:30 PM, Vito Caputo wrote: > Return directly from all switch cases, no point in storing in err. > > Signed-off-by: Vito Caputo <vcaputo@...garu.com> > --- > net/core/skbuff.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index f5f904f46893..c59b68a413b5 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -4888,23 +4888,14 @@ static int skb_checksum_setup_ipv6(struct sk_buff *skb, bool recalculate) > */ > int skb_checksum_setup(struct sk_buff *skb, bool recalculate) > { > - int err; > - > switch (skb->protocol) { > case htons(ETH_P_IP): > - err = skb_checksum_setup_ipv4(skb, recalculate); > - break; > - > + return skb_checksum_setup_ipv4(skb, recalculate); > case htons(ETH_P_IPV6): > - err = skb_checksum_setup_ipv6(skb, recalculate); > - break; > - > + return skb_checksum_setup_ipv6(skb, recalculate); > default: > - err = -EPROTO; > - break; > + return -EPROTO; > } > - > - return err; > } > EXPORT_SYMBOL(skb_checksum_setup); We prefer having a single return point in a function, if possible. The err variable would make easier for debugging support, if say a developer needs to trace this function.
Powered by blists - more mailing lists