netdev - Re: [PATCH V3 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8038c1e-35f2-4944-5802-8f7b8e3936f7@gmail.com>
Date:   Sun, 13 Oct 2019 13:41:24 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Marek Vasut <marex@...x.de>,
        Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        George McCollister <george.mccollister@...il.com>,
        Sean Nyekjaer <sean.nyekjaer@...vas.dk>,
        Tristram Ha <Tristram.Ha@...rochip.com>,
        Woojung Huh <woojung.huh@...rochip.com>
Subject: Re: [PATCH V3 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs



On 10/13/2019 1:29 PM, Marek Vasut wrote:
> On 10/13/19 10:15 PM, Heiner Kallweit wrote:
>> On 13.10.2019 21:34, Marek Vasut wrote:
>>> The KSZ8051 PHY and the KSZ8794/KSZ8795/KSZ8765 switch share exactly the
>>> same PHY ID. Since KSZ8051 is higher in the ksphy_driver[] list of PHYs
>>> in the micrel PHY driver, it is used even with the KSZ87xx switch. This
>>> is wrong, since the KSZ8051 configures registers of the PHY which are
>>> not present on the simplified KSZ87xx switch PHYs and misconfigures
>>> other registers of the KSZ87xx switch PHYs.
>>>
>>> Fortunatelly, it is possible to tell apart the KSZ8051 PHY from the
>>> KSZ87xx switch by checking the Basic Status register Bit 0, which is
>>> read-only and indicates presence of the Extended Capability Registers.
>>> The KSZ8051 PHY has those registers while the KSZ87xx switch does not.
>>>
>>> This patch implements simple check for the presence of this bit for
>>> both the KSZ8051 PHY and KSZ87xx switch, to let both use the correct
>>> PHY driver instance.
>>>
>>> Signed-off-by: Marek Vasut <marex@...x.de>
>>> Cc: Andrew Lunn <andrew@...n.ch>
>>> Cc: David S. Miller <davem@...emloft.net>
>>> Cc: Florian Fainelli <f.fainelli@...il.com>
>>> Cc: George McCollister <george.mccollister@...il.com>
>>> Cc: Heiner Kallweit <hkallweit1@...il.com>
>>> Cc: Sean Nyekjaer <sean.nyekjaer@...vas.dk>
>>> Cc: Tristram Ha <Tristram.Ha@...rochip.com>
>>> Cc: Woojung Huh <woojung.huh@...rochip.com>
>>> Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795")
>>
>> The Fixes tag has to be the first one. And patch still misses
>> the "net" annotation. For an example just see other fix submissions
>> on the mailing list.
> 
> The "net" annotation ? The net: tag is right there in the subject.
> 

It is missing from within the [PATCH] part of the subject, so it should
be [PATCH net] for the net tree (bugfixes) or [PATCH net-next] for
features (broadly speaking). This is explained in the netdev-FAQ that
Heiner pointed out previously:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n94
-- 
Florian