netdev - Re: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191012180340.57e5fbfb@cakuba.netronome.com>
Date:   Sat, 12 Oct 2019 18:03:40 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Anson Huang <anson.huang@....com>, Andy Duan <fugang.duan@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "swboyd@...omium.org" <swboyd@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 1/2] net: fec_main: Use
 platform_get_irq_byname_optional() to avoid error message

On Fri, 11 Oct 2019 12:55:20 +0300, Vladimir Oltean wrote:
> > > Unfortunately the networking subsystem sees around a 100 patches
> > > submitted each day, it'd be very hard to keep track of patches which have
> > > external dependencies and when to merge them. That's why we need the
> > > submitters to do this work for us and resubmit when the patch can be
> > > applied cleanly.  
> >
> > OK, I will resend this patch series once the necessary patch lands
> > on the network tree.  
> 
> What has not been mentioned is that you can't create future
> dependencies for patches which have a Fixes: tag.
> 
> git describe --tags 7723f4c5ecdb # driver core: platform: Add an error
> message to platform_get_irq*()
> v5.3-rc1-13-g7723f4c5ecdb
> 
> git describe --tags f1da567f1dc # driver core: platform: Add
> platform_get_irq_byname_optional()
> v5.4-rc1-46-gf1da567f1dc1

Ack, you raise some good points. AFAIU tho, in this case broken
patch, the dependency, and the fix are all targeting 5.4, so there
will be no real backporting hassle, while the presence of a Fixes 
tag makes it clear where the regression was introduced.