netdev - [PATCH] can: m_can: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Oct 2019 23:04:28 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Pankaj Sharma <pankj.sharma@...sung.com>
Cc:     kbuild-all@...ts.01.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        wg@...ndegger.com, mkl@...gutronix.de, davem@...emloft.net,
        eugen.hristev@...rochip.com, ludovic.desroches@...rochip.com,
        pankaj.dubey@...sung.com, rcsekar@...sung.com,
        Pankaj Sharma <pankj.sharma@...sung.com>,
        Sriram Dash <sriram.dash@...sung.com>
Subject: [PATCH] can: m_can: fix boolreturn.cocci warnings

From: kbuild test robot <lkp@...el.com>

drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function 'is_protocol_err' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 46946163ac61 ("can: m_can: add support for handling arbitration error")
CC: Pankaj Sharma <pankj.sharma@...sung.com>
Signed-off-by: kbuild test robot <lkp@...el.com>
---

url:    https://github.com/0day-ci/linux/commits/Pankaj-Sharma/can-m_can-add-support-for-handling-arbitration-error/20191014-193532

 m_can.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -780,9 +780,9 @@ static inline bool is_lec_err(u32 psr)
 static inline bool is_protocol_err(u32 irqstatus)
 {
 	if (irqstatus & IR_ERR_LEC_31X)
-		return 1;
+		return true;
 	else
-		return 0;
+		return false;
 }
 
 static int m_can_handle_protocol_error(struct net_device *dev, u32 irqstatus)