netdev - Re: [PATCH net-next v4 0/6] ipsec: add TCP encapsulation support (RFC 8229)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191014.144327.888902765137276425.davem@davemloft.net>
Date:   Mon, 14 Oct 2019 14:43:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     sd@...asysnail.net
Cc:     netdev@...r.kernel.org, herbert@...dor.apana.org.au,
        steffen.klassert@...unet.com
Subject: Re: [PATCH net-next v4 0/6] ipsec: add TCP encapsulation support
 (RFC 8229)

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Fri, 11 Oct 2019 16:57:23 +0200

> This patchset introduces support for TCP encapsulation of IKE and ESP
> messages, as defined by RFC 8229 [0]. It is an evolution of what
> Herbert Xu proposed in January 2018 [1] that addresses the main
> criticism against it, by not interfering with the TCP implementation
> at all. The networking stack now has infrastructure for this: TCP ULPs
> and Stream Parsers.

So this will bring up a re-occurring nightmare in that now we have another
situation where stacking ULPs would be necessary (kTLS over TCP encap) and
the ULP mechanism simply can't do this.

Last time this came up, it had to do with sock_map.  No way could be found
to stack ULPs properly, so instead sock_map was implemented via something
other than ULPs.

I fear we have the same situation here again and this issue must be
addressed before these patches are included.

Thanks.