netdev - Re: [PATCH v2 net-next 09/12] net: aquantia: implement get_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d78f0bee-2d7d-904d-9198-798edc4c3740@aquantia.com>
Date:   Mon, 14 Oct 2019 11:45:28 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Egor Pomozov <Egor.Pomozov@...antia.com>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Simon Edelhaus <sedelhaus@...vell.com>,
        Sergey Samoilenko <Sergey.Samoilenko@...antia.com>
Subject: Re: [PATCH v2 net-next 09/12] net: aquantia: implement get_ts_info
 ethtool


>> +
>> +	if (aq_nic->aq_ptp)
> 
> Shouldn't the test for (aq_nic->aq_ptp) also effect
> info->so_timestamping and info->tx_types ?

You are right, it should.
It should also fallback to software ethtool_op_get_ts_info in
case HW is not PTP capable.

Will fix that.

Regards,
  Igor