netdev - Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX License Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191014130016.GD19861@lunn.ch>
Date:   Mon, 14 Oct 2019 15:00:16 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Nishad Kamdar <nishadkamdar@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, netdev <netdev@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: sja1105: Use the correct style for SPDX
 License Identifier

On Mon, Oct 14, 2019 at 01:46:26PM +0300, Vladimir Oltean wrote:
> Hi Nishad,
> 
> On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <nishadkamdar@...il.com> wrote:
> >
> > This patch corrects the SPDX License Identifier style
> > in header files related to Distributed Switch Architecture
> > drivers for NXP SJA1105 series Ethernet switch support.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used)
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <joe@...ches.com>
> > Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> > ---
> 
> Your commit message has nothing to do with what you're fixing, but
> whatever. The SPDX identifiers _are_ using C-like comments.

Agreed. Please fix the commit message, and maybe make the script
generating the commit message, so future uses of it will get the
message correct.

Thanks
	Andrew