netdev - Re: [PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30809d50-a9ba-881b-1d3b-f3582c14cf79@gmail.com>
Date:   Tue, 15 Oct 2019 13:47:32 -0400
From:   Jes Sorensen <jes.sorensen@...il.com>
To:     Chris Chiu <chiu@...lessm.com>, kvalo@...eaurora.org,
        davem@...emloft.net
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux@...lessm.com
Subject: Re: [PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after
 warm reboot

On 10/15/19 6:19 AM, Chris Chiu wrote:
> The RTL8723BU has problems connecting to AP after each warm reboot.
> Sometimes it returns no scan result, and in most cases, it fails
> the authentication for unknown reason. However, it works totally
> fine after cold reboot.
> 
> Compare the value of register SYS_CR and SYS_CLK_MAC_CLK_ENABLE
> for cold reboot and warm reboot, the registers imply that the MAC
> is already powered and thus some procedures are skipped during
> driver initialization. Double checked the vendor driver, it reads
> the SYS_CR and SYS_CLK_MAC_CLK_ENABLE also but doesn't skip any
> during initialization based on them. This commit only tells the
> RTL8723BU to do full initilization without checking MAC status.
> 
> Signed-off-by: Chris Chiu <chiu@...lessm.com>
> ---
>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h       | 1 +
>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 +
>   drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c  | 3 +++
>   3 files changed, 5 insertions(+)

Looks good to me! If this takes care of the warm boot problem, that's 
pretty awesome.

Signed-off-by: Jes Sorensen <Jes.Sorensen@...il.com>

Jes