netdev - Re: [PATCH net-next,v5 3/4] net: flow_offload: mangle action at byte level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Oct 2019 16:48:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     kbuild-all@...ts.01.org, netfilter-devel@...r.kernel.org,
        davem@...emloft.net, netdev@...r.kernel.org,
        jakub.kicinski@...ronome.com, jiri@...nulli.us,
        saeedm@...lanox.com, vishal@...lsio.com, vladbu@...lanox.com,
        ecree@...arflare.com
Subject: Re: [PATCH net-next,v5 3/4] net: flow_offload: mangle action at byte
 level

Hi Pablo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[cannot apply to v5.4-rc3 next-20191014]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/flow_offload-update-mangle-action-representation/20191015-061232
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-43-g0ccb3b4-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

   net/sched/cls_api.c:200:22: sparse: sparse: incorrect type in assignment (different base types) @@    expected restricted __be16 [usertype] protocol @@    got icted __be16 [usertype] protocol @@
   net/sched/cls_api.c:200:22: sparse:    expected restricted __be16 [usertype] protocol
   net/sched/cls_api.c:200:22: sparse:    got unsigned int [usertype] protocol
   net/sched/cls_api.c:1587:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1587:16: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1587:16: sparse:    struct tcf_proto [noderef] <asn:4> *
   net/sched/cls_api.c:1680:20: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1680:20: sparse:    struct tcf_proto [noderef] <asn:4> *
   net/sched/cls_api.c:1680:20: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1643:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1643:25: sparse:    struct tcf_proto [noderef] <asn:4> *
   net/sched/cls_api.c:1643:25: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1662:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
   net/sched/cls_api.c:1662:16: sparse:    struct tcf_proto *
   net/sched/cls_api.c:1662:16: sparse:    struct tcf_proto [noderef] <asn:4> *
   net/sched/cls_api.c:1727:25: sparse: sparse: restricted __be16 degrades to integer
   net/sched/cls_api.c:2372:50: sparse: sparse: restricted __be16 degrades to integer
>> net/sched/cls_api.c:3396:27: sparse: sparse: symbol 'tc_proto_udp_hdr' was not declared. Should it be static?
>> net/sched/cls_api.c:3499:27: sparse: sparse: cast to restricted __be32
>> net/sched/cls_api.c:3499:27: sparse: sparse: cast to restricted __be32
>> net/sched/cls_api.c:3499:27: sparse: sparse: cast to restricted __be32
>> net/sched/cls_api.c:3499:27: sparse: sparse: cast to restricted __be32
>> net/sched/cls_api.c:3499:27: sparse: sparse: cast to restricted __be32
>> net/sched/cls_api.c:3499:27: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3533:33: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3533:33: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3533:33: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3533:33: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3533:33: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3533:33: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3543:25: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3543:25: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3543:25: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3543:25: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3543:25: sparse: sparse: cast to restricted __be32
   net/sched/cls_api.c:3543:25: sparse: sparse: cast to restricted __be32

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation