netdev - Re: [PATCHv3 next] blackhole_netdev: fix syzkaller reported issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF2d9jiXqpVXmh--RzyJc5L7b3Ee7Sz94RqJZNxDDA0D7j8APA@mail.gmail.com>
Date:   Wed, 16 Oct 2019 00:01:50 -0700
From:   Mahesh Bandewar (महेश बंडेवार) 
        <maheshb@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     linux-netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Wei Wang <weiwan@...gle.com>, mahesh@...dewar.net
Subject: Re: [PATCHv3 next] blackhole_netdev: fix syzkaller reported issue

On Tue, Oct 15, 2019 at 10:36 AM David Miller <davem@...emloft.net> wrote:
>
> From: Mahesh Bandewar <maheshb@...gle.com>
> Date: Fri, 11 Oct 2019 18:14:55 -0700
>
> > While invalidating the dst, we assign backhole_netdev instead of
> > loopback device. However, this device does not have idev pointer
> > and hence no ip6_ptr even if IPv6 is enabled. Possibly this has
> > triggered the syzbot reported crash.
> >
> > The syzbot report does not have reproducer, however, this is the
> > only device that doesn't have matching idev created.
> >
> > Crash instruction is :
> >
> > static inline bool ip6_ignore_linkdown(const struct net_device *dev)
> > {
> >         const struct inet6_dev *idev = __in6_dev_get(dev);
> >
> >         return !!idev->cnf.ignore_routes_with_linkdown; <= crash
> > }
> >
> > Also ipv6 always assumes presence of idev and never checks for it
> > being NULL (as does the above referenced code). So adding a idev
> > for the blackhole_netdev to avoid this class of crashes in the future.
> >
> > ---
>  ...
> > Fixes: 8d7017fd621d ("blackhole_netdev: use blackhole_netdev to invalidate dst entries")
> > Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
>
> Applied and queued up for -stable, thanks.

Hi David,
I just started seeing pretty weird behavior in IPv6 stack after this
patch being applied to the net/stable branch. I'm suspecting it's my
patch especially after the v2/v3 changes as I didn't see any other
IPv6 changes in net/branch. I propose to revert this and take a closer
look so that it doesn't spill any further. I'll post a revert soon.

thanks,
--mahesh..