netdev - Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Oct 2019 10:31:31 +0300
From:   Alexander Lobakin <alobakin@...nk.ru>
To:     David Miller <davem@...emloft.net>
Cc:     ecree@...arflare.com, jiri@...lanox.com, edumazet@...gle.com,
        idosch@...lanox.com, pabeni@...hat.com, petrm@...lanox.com,
        sd@...asysnail.net, f.fainelli@...il.com,
        jaswinder.singh@...aro.org, ilias.apalodimas@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in
 napi_gro_receive()

David Miller wrote 16.10.2019 04:16:
> From: Alexander Lobakin <alobakin@...nk.ru>
> Date: Mon, 14 Oct 2019 11:00:33 +0300
> 
>> Commit 323ebb61e32b4 ("net: use listified RX for handling GRO_NORMAL
>> skbs") made use of listified skb processing for the users of
>> napi_gro_frags().
>> The same technique can be used in a way more common napi_gro_receive()
>> to speed up non-merged (GRO_NORMAL) skbs for a wide range of drivers
>> including gro_cells and mac80211 users.
>> This slightly changes the return value in cases where skb is being
>> dropped by the core stack, but it seems to have no impact on related
>> drivers' functionality.
>> gro_normal_batch is left untouched as it's very individual for every
>> single system configuration and might be tuned in manual order to
>> achieve an optimal performance.
>> 
>> Signed-off-by: Alexander Lobakin <alobakin@...nk.ru>
>> Acked-by: Edward Cree <ecree@...arflare.com>
> 
> Applied, thank you.

David, Edward, Eric, Ilias,
thank you for your time.

Regards,
ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ