netdev - RE: [PATCHv3 net-next 0/5] sctp: update from rfc7829

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f6cf86fce074a9cbf7f8c2496cc7c84@AcuMS.aculab.com>
Date:   Wed, 16 Oct 2019 10:42:23 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'David Miller' <davem@...emloft.net>,
        "lucien.xin@...il.com" <lucien.xin@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-sctp@...r.kernel.org" <linux-sctp@...r.kernel.org>,
        "marcelo.leitner@...il.com" <marcelo.leitner@...il.com>,
        "nhorman@...driver.com" <nhorman@...driver.com>
Subject: RE: [PATCHv3 net-next 0/5] sctp: update from rfc7829

From: David Miller
> Sent: 16 October 2019 01:57
> From: Xin Long <lucien.xin@...il.com>
> Date: Mon, 14 Oct 2019 14:14:43 +0800
> 
> > SCTP-PF was implemented based on a Internet-Draft in 2012:
> >
> >   https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
> >
> > It's been updated quite a few by rfc7829 in 2016.
> >
> > This patchset adds the following features:
> >
> >   1. add SCTP_ADDR_POTENTIALLY_FAILED notification
> >   2. add pf_expose per netns/sock/asoc
> >   3. add SCTP_EXPOSE_POTENTIALLY_FAILED_STATE sockopt
> >   4. add ps_retrans per netns/sock/asoc/transport
> >      (Primary Path Switchover)
> >   5. add spt_pathcpthld for SCTP_PEER_ADDR_THLDS sockopt
> 
> I would like to see some SCTP expert ACKs here.

I'm only an SCTP user, but I think some of the API changes aren't right.
I'm not going to try to grok the sctp code - it makes my brain hurt.
(Even though I've written plenty of protocol stack code.)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)