netdev - Re: [PATCHv3 net-next 0/5] sctp: update from rfc7829

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191016.120419.1631440501656175018.davem@davemloft.net>
Date:   Wed, 16 Oct 2019 12:04:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     marcelo.leitner@...il.com
Cc:     lucien.xin@...il.com, netdev@...r.kernel.org,
        linux-sctp@...r.kernel.org, nhorman@...driver.com,
        david.laight@...lab.com
Subject: Re: [PATCHv3 net-next 0/5] sctp: update from rfc7829

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Wed, 16 Oct 2019 15:32:09 -0300

> On Wed, Oct 16, 2019 at 02:25:34PM -0400, David Miller wrote:
>> From: Xin Long <lucien.xin@...il.com>
>> Date: Mon, 14 Oct 2019 14:14:43 +0800
>> 
>> > SCTP-PF was implemented based on a Internet-Draft in 2012:
>> > 
>> >   https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
>> > 
>> > It's been updated quite a few by rfc7829 in 2016.
>> > 
>> > This patchset adds the following features:
>> 
>> Sorry but I'm tossing these until an knowledgable SCTP person can
>> look at them.
> 
> Hi Dave,
> 
> Maybe the email didn't get through but Neil actually already acked it,
> 2 days ago.
>   Message-ID: <20191014124249.GB11844@...warspite.think-freely.org>
> 
> I won't be able to review it :-(

All I saw was David Laight replying saying he thought the APIs weren't
implemented correctly.

I have to admit that I'm really going to proceed carefully with SCTP
API changes because there has been a lot of discussions in the past
involving backwards-incompatible things happening.

I'm not saying that is happening here, but my confidence in SCTP API
changes is very low.

I want this to sit for a while and Xin can respin and resubmit in a
day or two.