netdev - Re: [PATCH net] cxgb4: Fix panic when attaching to ULD fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191016.121950.1487403738523364817.davem@davemloft.net>
Date:   Wed, 16 Oct 2019 12:19:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vishal@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com, shahjada@...lsio.com
Subject: Re: [PATCH net] cxgb4: Fix panic when attaching to ULD fails

From: Vishal Kulkarni <vishal@...lsio.com>
Date: Mon, 14 Oct 2019 13:20:35 +0530

> @@ -760,7 +762,9 @@ void cxgb4_register_uld(enum cxgb4_uld type,
>  		if (ret)
>  			goto free_irq;
>  		adap->uld[type] = *p;
> -		uld_attach(adap, type);
> +		ret = uld_attach(adap, type);
> +		if (ret)
> +			goto free_irq;

You're not freeing up all of the txq_info ULD stuff that setup_sge_txq_uld
created.