netdev - Re: [PATCH net] net: phy: Fix "link partner" information disappear issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191016.131801.2242669095837757698.davem@davemloft.net>
Date:   Wed, 16 Oct 2019 13:18:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liuyonglong@...wei.com
Cc:     hkallweit1@...il.com, andrew@...n.ch, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        shiju.jose@...wei.com
Subject: Re: [PATCH net] net: phy: Fix "link partner" information disappear
 issue

From: Yonglong Liu <liuyonglong@...wei.com>
Date: Wed, 16 Oct 2019 10:30:39 +0800

> Some drivers just call phy_ethtool_ksettings_set() to set the
> links, for those phy drivers that use genphy_read_status(), if
> autoneg is on, and the link is up, than execute "ethtool -s
> ethx autoneg on" will cause "link partner" information disappear.
> 
> The call trace is phy_ethtool_ksettings_set()->phy_start_aneg()
> ->linkmode_zero(phydev->lp_advertising)->genphy_read_status(),
> the link didn't change, so genphy_read_status() just return, and
> phydev->lp_advertising is zero now.
> 
> This patch moves the clear operation of lp_advertising from
> phy_start_aneg() to genphy_read_lpa()/genphy_c45_read_lpa(), and
> if autoneg on and autoneg not complete, just clear what the
> generic functions care about.
> 
> Fixes: 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in genphy_read_status")
> Signed-off-by: Yonglong Liu <liuyonglong@...wei.com>

Applied and queued up for -stable, thank you.