netdev - Re: [net-next 1/7] igb/igc: Don't warn on fatal read failures when the device is removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191016165848.46341167@cakuba.netronome.com>
Date:   Wed, 16 Oct 2019 16:58:48 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, Lyude Paul <lyude@...hat.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Sasha Neftin <sasha.neftin@...el.com>,
        Aaron Brown <aaron.f.brown@...el.com>,
        Feng Tang <feng.tang@...el.com>
Subject: Re: [net-next 1/7] igb/igc: Don't warn on fatal read failures when
 the device is removed

On Wed, 16 Oct 2019 16:47:05 -0700, Jeff Kirsher wrote:
> From: Lyude Paul <lyude@...hat.com>
> 
> Fatal read errors are worth warning about, unless of course the device
> was just unplugged from the machine - something that's a rather normal
> occurence when the igb/igc adapter is located on a Thunderbolt dock. So,
> let's only WARN() if there's a fatal read error while the device is
> still present.
> 
> This fixes the following WARN splat that's been appearing whenever I
> unplug my Caldigit TS3 Thunderbolt dock from my laptop:
> 
>  [...]
> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Fixes: 47e16692b26b ("igb/igc: warn when fatal read failure happens")
> Acked-by: Sasha Neftin <sasha.neftin@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Acked-by: Feng Tang <feng.tang@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Any plans to start sending fixes to net? :(