netdev - Re: [PATCH net-next v2] hv_sock: use HV_HYP_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191015.172701.464446938727284882.davem@davemloft.net>
Date:   Tue, 15 Oct 2019 17:27:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mikelley@...rosoft.com
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        sashal@...nel.org, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        himadrispandya@...il.com
Subject: Re: [PATCH net-next v2] hv_sock: use HV_HYP_PAGE_SIZE for Hyper-V
 communication

From: Michael Kelley <mikelley@...rosoft.com>
Date: Sun, 13 Oct 2019 00:30:21 +0000

> From: Himadri Pandya <himadrispandya@...il.com>
> 
> Current code assumes PAGE_SIZE (the guest page size) is equal
> to the page size used to communicate with Hyper-V (which is
> always 4K). While this assumption is true on x86, it may not
> be true for Hyper-V on other architectures. For example,
> Linux on ARM64 may have PAGE_SIZE of 16K or 64K. A new symbol,
> HV_HYP_PAGE_SIZE, has been previously introduced to use when
> the Hyper-V page size is intended instead of the guest page size.
> 
> Make this code work on non-x86 architectures by using the new
> HV_HYP_PAGE_SIZE symbol instead of PAGE_SIZE, where appropriate.
> Also replace the now redundant PAGE_SIZE_4K with HV_HYP_PAGE_SIZE.
> The change has no effect on x86, but lays the groundwork to run
> on ARM64 and others.
> 
> Signed-off-by: Himadri Pandya <himadrispandya@...il.com>
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
> ---
> 
> Changes in v2:
> * Revised commit message and subject [Jakub Kicinski]

Applied, thank you.