netdev - Re: [PATCH net v1] sched: etf: Fix ordering of packets with same txtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191015.203327.2130838944283050049.davem@davemloft.net>
Date:   Tue, 15 Oct 2019 20:33:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vinicius.gomes@...el.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, ederson.desouza@...el.com
Subject: Re: [PATCH net v1] sched: etf: Fix ordering of packets with same
 txtime

From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
Date: Mon, 14 Oct 2019 13:38:22 -0700

> When a application sends many packets with the same txtime, they may
> be transmitted out of order (different from the order in which they
> were enqueued).
> 
> This happens because when inserting elements into the tree, when the
> txtime of two packets are the same, the new packet is inserted at the
> left side of the tree, causing the reordering. The only effect of this
> change should be that packets with the same txtime will be transmitted
> in the order they are enqueued.
> 
> The application in question (the AVTP GStreamer plugin, still in
> development) is sending video traffic, in which each video frame have
> a single presentation time, the problem is that when packetizing,
> multiple packets end up with the same txtime.
> 
> The receiving side was rejecting packets because they were being
> received out of order.
> 
> Fixes: 25db26a91364 ("net/sched: Introduce the ETF Qdisc")
> Reported-by: Ederson de Souza <ederson.desouza@...el.com>
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>

Applied and queued up for -stable, thank you.