netdev - Re: [PATCH V2 2/2] net: dsa: microchip: Add shared regmap mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191015.173735.680126764547812788.davem@davemloft.net>
Date:   Tue, 15 Oct 2019 17:37:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     marex@...x.de
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
        george.mccollister@...il.com, Tristram.Ha@...rochip.com,
        woojung.huh@...rochip.com
Subject: Re: [PATCH V2 2/2] net: dsa: microchip: Add shared regmap mutex

From: Marek Vasut <marex@...x.de>
Date: Sun, 13 Oct 2019 21:32:38 +0200

> diff --git a/drivers/net/dsa/microchip/ksz8795_spi.c b/drivers/net/dsa/microchip/ksz8795_spi.c
> index d0f8153e86b7..614404c40cba 100644
> --- a/drivers/net/dsa/microchip/ksz8795_spi.c
> +++ b/drivers/net/dsa/microchip/ksz8795_spi.c
> @@ -26,6 +26,7 @@ KSZ_REGMAP_TABLE(ksz8795, 16, SPI_ADDR_SHIFT,
>  static int ksz8795_spi_probe(struct spi_device *spi)
>  {
>  	struct ksz_device *dev;
> +	struct regmap_config rc;
>  	int i, ret;

Please retain the reverse christmas tree ordering of local variables
here.

> @@ -18,6 +18,7 @@ static int ksz9477_i2c_probe(struct i2c_client *i2c,
>  			     const struct i2c_device_id *i2c_id)
>  {
>  	struct ksz_device *dev;
> +	struct regmap_config rc;
>  	int i, ret;

Likewise.

> @@ -25,6 +25,7 @@ KSZ_REGMAP_TABLE(ksz9477, 32, SPI_ADDR_SHIFT,
>  static int ksz9477_spi_probe(struct spi_device *spi)
>  {
>  	struct ksz_device *dev;
> +	struct regmap_config rc;
>  	int i, ret;

Likewise.