netdev - Re: [PATCH v2 bpf-next 5/6] selftests/bpf: replace test_progs and test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <112cd221-7403-efe2-3375-bb9cc8140744@fb.com>
Date:   Wed, 16 Oct 2019 05:11:40 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Andrii Nakryiko <andriin@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>
CC:     "andrii.nakryiko@...il.com" <andrii.nakryiko@...il.com>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next 5/6] selftests/bpf: replace test_progs and
 test_maps w/ general rule

On 10/15/19 8:29 PM, Andrii Nakryiko wrote:
> Makefile:282: warning: overriding recipe for target
> `/data/users/andriin/linux/tools/testing/selftests/bpf/test_xdp.o'
> Makefile:277: warning: ignoring old recipe for target
> `/data/users/andriin/linux/tools/testing/selftests/bpf/test_xdp.o'

I thought I can live with it, but no. It's too annoying.
Any make clean or make prints it.

Also looking at commit f96afa767baf ("selftests/bpf: enable (uncomment) 
all tests in test_libbpf.sh") that introduced this stuff...
I think it's all obsolete now.
test_libbpf* can be removed. test_progs nowadays do a lot more
than this mini-test.
Doing a test with clang native | llc -march=bpf is still useful,
but at this shape of test_libbpf it's pointless to continue doing so.
Such clang native test should be properly integrated into test_progs.
For now I suggest to remove this extra test_xdp.o recompilation
and remove test_libbpf*