netdev - Re: [PATCH bpf-next] bpf: add new helper fd2path for mapping a file descriptor to a pathname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <365b18db-cf7f-1d1d-f048-7220eb702e8f@iogearbox.net>
Date:   Thu, 17 Oct 2019 16:49:48 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Zwb <ethercflow@...il.com>, netdev@...r.kernel.org
Cc:     yhs@...com
Subject: Re: [PATCH bpf-next] bpf: add new helper fd2path for mapping a file
 descriptor to a pathname

On 10/17/19 11:26 AM, Zwb wrote:
> When people want to identify which file system files are being opened,
> read, and written to, they can use this helper with file descriptor as
> input to achieve this goal. Other pseudo filesystems are also supported.
> 
> Signed-off-by: Zwb <ethercflow@...il.com>

SOB requires that there is a proper name, see Documentation/process/submitting-patches.rst +431.

[...]
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index a65c3b0c6935..a4a5d432e572 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -2769,6 +2769,7 @@ union bpf_attr {
>   	FN(get_current_pid_tgid),	\
>   	FN(get_current_uid_gid),	\
>   	FN(get_current_comm),		\
> +	FN(fd2path),			\

Adding into the middle will break existing BPF programs. Helper description is also missing.

>   	FN(get_cgroup_classid),		\
>   	FN(skb_vlan_push),		\
>   	FN(skb_vlan_pop),		\