netdev - Re: [patch iproute2-next v3 2/2] ip: allow to use alternative names as handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191017171421.GB2185@nanopsycho>
Date:   Thu, 17 Oct 2019 19:14:21 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        jakub.kicinski@...ronome.com, stephen@...workplumber.org,
        roopa@...ulusnetworks.com, dcbw@...hat.com,
        nikolay@...ulusnetworks.com, mkubecek@...e.cz, andrew@...n.ch,
        parav@...lanox.com, saeedm@...lanox.com, f.fainelli@...il.com,
        sd@...asysnail.net, sbrivio@...hat.com, pabeni@...hat.com,
        mlxsw@...lanox.com
Subject: Re: [patch iproute2-next v3 2/2] ip: allow to use alternative names
 as handle

Thu, Oct 17, 2019 at 05:34:54PM CEST, dsahern@...il.com wrote:
>On 10/16/19 7:28 AM, Jiri Pirko wrote:
>> Tue, Oct 15, 2019 at 08:34:56PM CEST, dsahern@...il.com wrote:
>>> On 10/9/19 8:49 AM, Jiri Pirko wrote:
>>>> From: Jiri Pirko <jiri@...lanox.com>
>>>>
>>>> Extend ll_name_to_index() to get the index of a netdevice using
>>>> alternative interface name. Allow alternative long names to pass checks
>>>> in couple of ip link/addr commands.
>>>
>>> you don't add altnames to the name_hash, so the lookup can not find a
>>> match based on altname.
>> 
>> you are right, it is always going to fall back to ll_link_get(). I will
>> do another patch to add the altnames to name_hash. It can go in
>> separatelly or I can add that to this patchset. Up to you.
>
>this patch claims to do the lookup, so it should actually be able to do
>a lookup.

Allright.