netdev - Re: [PATCH net-next,v5 3/4] net: flow_offload: mangle action at byte level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191017.140251.1580977190222713975.davem@davemloft.net>
Date:   Thu, 17 Oct 2019 14:02:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     pablo@...filter.org, jakub.kicinski@...ronome.com,
        netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        jiri@...nulli.us, saeedm@...lanox.com, vishal@...lsio.com,
        vladbu@...lanox.com
Subject: Re: [PATCH net-next,v5 3/4] net: flow_offload: mangle action at
 byte level

From: Edward Cree <ecree@...arflare.com>
Date: Thu, 17 Oct 2019 18:59:22 +0100

> Pedit is supposed to work even in the absence of protocol knowledge in
>  the kernel (e.g. in combination with cls_u32, you can filter and mangle
>  traffic in a completely new protocol), you're turning it into Yet
>  Another Ossified TCP/IP Monoculture.  This is not the direction the
>  networking offloads community is trying to move in.

Agreed, the proposed changes are taking the code and interfaces in
completely the wrong direction.

I agree with Jakub and Edward on all of these points.