netdev - Re: [PATCH] usb: hso: obey DMA rules in tiocmget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191017.142055.130965767343659716.davem@davemloft.net>
Date:   Thu, 17 Oct 2019 14:20:55 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     oneukum@...e.com
Cc:     netdev@...r.kernel.org, johan@...nel.org
Subject: Re: [PATCH] usb: hso: obey DMA rules in tiocmget

From: David Miller <davem@...emloft.net>
Date: Thu, 17 Oct 2019 14:19:55 -0400 (EDT)

> From: Oliver Neukum <oneukum@...e.com>
> Date: Thu, 17 Oct 2019 11:53:38 +0200
> 
>> The serial state information must not be embedded into another
>> data structure, as this interferes with cache handling for DMA
>> on architectures without cache coherence..
>> That would result in data corruption on some architectures
>> Allocating it separately.
>> 
>> Signed-off-by: Oliver Neukum <oneukum@...e.com>
> 
> Applied, thanks Oliver.

Ugh, Oliver did you even build test this?

drivers/net/usb/hso.c:189:9: error: expected ‘{’ before ‘*’ token
  189 |  struct *hso_serial_state_notification serial_state_notification;

Seriously, I expect better from an experienced developer such as
yourself.