netdev - Re: [net-next 2/7] igb: add rx drop enable attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a575469d3b2a12d24161d0c6b0a6bff538e066b6.camel@collabora.com>
Date:   Thu, 17 Oct 2019 12:24:03 +0100
From:   Robert Beckett <bob.beckett@...labora.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, Aaron Brown <aaron.f.brown@...el.com>
Subject: Re: [net-next 2/7] igb: add rx drop enable attribute

On Wed, 2019-10-16 at 16:55 -0700, Jakub Kicinski wrote:
> On Wed, 16 Oct 2019 16:47:06 -0700, Jeff Kirsher wrote:
> > From: Robert Beckett <bob.beckett@...labora.com>
> > 
> > To allow userland to enable or disable dropping packets when
> > descriptor
> > ring is exhausted, add RX_DROP_EN private flag.
> > 
> > This can be used in conjunction with flow control to mitigate
> > packet storms
> > (e.g. due to network loop or DoS) by forcing the network adapter to
> > send
> > pause frames whenever the ring is close to exhaustion.
> > 
> > By default this will maintain previous behaviour of enabling
> > dropping of
> > packets during ring buffer exhaustion.
> > Some use cases prefer to not drop packets upon exhaustion, but
> > instead
> > use flow control to limit ingress rates and ensure no dropped
> > packets.
> > This is useful when the host CPU cannot keep up with packet
> > delivery,
> > but data delivery is more important than throughput via multiple
> > queues.
> > 
> > Userland can set this flag to 0 via ethtool to disable packet
> > dropping.
> > 
> > Signed-off-by: Robert Beckett <bob.beckett@...labora.com>
> > Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> How is this different than enabling/disabling flow control..
> 
> ethtool -a/-A

Enabling flow control enables the advertisement of flow control
capabilites and allows negotiation with link partner. It does not
dictate under which circumstances those pause frames will be emitted.

This patch enables an igb specific feature that can cause flow control
to be used. The default behaviour is to drop packets if the rx ring
buffer fills. This flag tells the driver instead to emit pause frames
and not drop packets, which is useful when reliable data delivery is
more important than throughput.