netdev - Re: [PATCH net v2 0/2] net: netem: fix further issues with packet corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018093614.32a023fd@hermes.lan>
Date:   Fri, 18 Oct 2019 09:36:14 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, xiyou.wangcong@...il.com
Subject: Re: [PATCH net v2 0/2] net: netem: fix further issues with packet
 corruption

On Fri, 18 Oct 2019 09:16:56 -0700
Jakub Kicinski <jakub.kicinski@...ronome.com> wrote:

> Hi!
> 
> This set is fixing two more issues with the netem packet corruption.
> 
> First patch (which was previously posted) avoids NULL pointer dereference
> if the first frame gets freed due to allocation or checksum failure.
> v2 improves the clarity of the code a little as requested by Cong.
> 
> Second patch ensures we don't return SUCCESS if the frame was in fact
> dropped. Thanks to this commit message for patch 1 no longer needs the
> "this will still break with a single-frame failure" disclaimer.
> 
> Jakub Kicinski (2):
>   net: netem: fix error path for corrupted GSO frames
>   net: netem: correct the parent's backlog when corrupted packet was
>     dropped
> 
>  net/sched/sch_netem.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 


LGTM

Acked-by: Stephen Hemminger <stephen@...workplumber.org>