netdev - Re: [patch net-next] devlink: add format requirement for devlink param names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018165855.GH2185@nanopsycho>
Date:   Fri, 18 Oct 2019 18:58:55 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, andrew@...n.ch,
        mlxsw@...lanox.com
Subject: Re: [patch net-next] devlink: add format requirement for devlink
 param names

Fri, Oct 18, 2019 at 06:25:50PM CEST, jakub.kicinski@...ronome.com wrote:
>On Fri, 18 Oct 2019 18:07:26 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Currently, the name format is not required by the code, however it is
>> required during patch review. All params added until now are in-lined
>> with the following format:
>> 1) lowercase characters, digits and underscored are allowed
>> 2) underscore is neither at the beginning nor at the end and
>>    there is no more than one in a row.
>> 
>> Add checker to the code to require this format from drivers and warn if
>> they don't follow.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>
>Looks good, I could nit pick that length of 0 could also be disallowed
>since we're checking validity, but why would I :)

Okay.

>
>Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>