netdev - Re: [PATCH net] net: ensure correct skb->tstamp in various fragmenters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191018.130332.850928941409040390.davem@davemloft.net>
Date:   Fri, 18 Oct 2019 13:03:32 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        Thomas.Bartschies@....de
Subject: Re: [PATCH net] net: ensure correct skb->tstamp in various
 fragmenters

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 16 Oct 2019 18:00:56 -0700

> Thomas found that some forwarded packets would be stuck
> in FQ packet scheduler because their skb->tstamp contained
> timestamps far in the future.
> 
> We thought we addressed this point in commit 8203e2d844d3
> ("net: clear skb->tstamp in forwarding paths") but there
> is still an issue when/if a packet needs to be fragmented.
> 
> In order to meet EDT requirements, we have to make sure all
> fragments get the original skb->tstamp.
> 
> Note that this original skb->tstamp should be zero in
> forwarding path, but might have a non zero value in
> output path if user decided so.
> 
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Thomas Bartschies <Thomas.Bartschies@....de>

Applied and queued up for -stable, thanks Eric.