netdev - Re: [PATCH net] mlxsw: spectrum_trap: Push Ethernet header before reporting trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191018.131546.106406470055738848.davem@davemloft.net>
Date:   Fri, 18 Oct 2019 13:15:46 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, alexanderk@...lanox.com,
        mlxsw@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net] mlxsw: spectrum_trap: Push Ethernet header before
 reporting trap

From: Ido Schimmel <idosch@...sch.org>
Date: Thu, 17 Oct 2019 10:11:03 +0300

> From: Ido Schimmel <idosch@...lanox.com>
> 
> devlink maintains packets and bytes statistics for each trap. Since
> eth_type_trans() was called to set the skb's protocol, the data pointer
> no longer points to the start of the packet and the bytes accounting is
> off by 14 bytes.
> 
> Fix this by pushing the skb's data pointer to the start of the packet.
> 
> Fixes: b5ce611fd96e ("mlxsw: spectrum: Add devlink-trap support")
> Reported-by: Alex Kushnarov <alexanderk@...lanox.com>
> Tested-by: Alex Kushnarov <alexanderk@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied, thanks.