netdev - Re: [PATCH bpf] selftests/bpf: More compatible nc options in test_tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Oct 2019 11:51:44 -0700
From:   Peter Oskolkov <posk@...k.io>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     bpf <bpf@...r.kernel.org>, linux-netdev <netdev@...r.kernel.org>,
        Peter Oskolkov <posk@...gle.com>
Subject: Re: [PATCH bpf] selftests/bpf: More compatible nc options in test_tc_edt

On Fri, Oct 18, 2019 at 5:00 AM Jiri Benc <jbenc@...hat.com> wrote:
>
> Out of the three nc implementations widely in use, at least two (BSD netcat
> and nmap-ncat) do not support -l combined with -s. Modify the nc invocation
> to be accepted by all of them.
>
> Fixes: 7df5e3db8f63 ("selftests: bpf: tc-bpf flow shaping with EDT")
> Cc: Peter Oskolkov <posk@...gle.com>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>
> ---
>  tools/testing/selftests/bpf/test_tc_edt.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_tc_edt.sh b/tools/testing/selftests/bpf/test_tc_edt.sh
> index f38567ef694b..daa7d1b8d309 100755
> --- a/tools/testing/selftests/bpf/test_tc_edt.sh
> +++ b/tools/testing/selftests/bpf/test_tc_edt.sh
> @@ -59,7 +59,7 @@ ip netns exec ${NS_SRC} tc filter add dev veth_src egress \
>
>  # start the listener
>  ip netns exec ${NS_DST} bash -c \
> -       "nc -4 -l -s ${IP_DST} -p 9000 >/dev/null &"
> +       "nc -4 -l -p 9000 >/dev/null &"

The test passes with the regular linux/debian nc. If it passes will the rest,

Acked-by: Peter Oskolkov <posk@...gle.com>

>  declare -i NC_PID=$!
>  sleep 1
>
> --
> 2.18.1
>