netdev - Re: [PATCH 00/10 net-next] page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02eb26349dfe19d41f9b81b35fdb2b1e14008b7e.camel@mellanox.com>
Date:   Fri, 18 Oct 2019 21:21:41 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "jonathan.lemon@...il.com" <jonathan.lemon@...il.com>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        "brouer@...hat.com" <brouer@...hat.com>
CC:     "kernel-team@...com" <kernel-team@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 00/10 net-next] page_pool cleanups

On Fri, 2019-10-18 at 13:50 -0700, Saeed Mahameed wrote:
> On Wed, 2019-10-16 at 15:50 -0700, Jonathan Lemon wrote:
> > This patch combines work from various people:
> > - part of Tariq's work to move the DMA mapping from
> >   the mlx5 driver into the page pool.  This does not
> >   include later patches which remove the dma address
> >   from the driver, as this conflicts with AF_XDP.
> > 
> > - Saeed's changes to check the numa node before
> >   including the page in the pool, and flushing the
> >   pool on a node change.
> > 
> 
> Hi Jonathan, thanks for submitting this,
> the patches you have are not up to date, i have new ones with tracing
> support and some fixes from offlist review iterations, plus
> performance
> numbers and a  cover letter. 
> 
> I will send it to you and you can post it as v2 ? 

actually i suggest to take my 3 patches out of this series and submit
them as standalone, they are not directly related to the other stuff
here, and can perfectly work without them, since my 3 patches are
addressing a real issue with page pool numa node migration.

> 
> 
> > - Statistics and cleanup for page pool.
> > 
> > Jonathan Lemon (5):
> >   page_pool: Add page_pool_keep_page
> >   page_pool: allow configurable linear cache size
> >   page_pool: Add statistics
> >   net/mlx5: Add page_pool stats to the Mellanox driver
> >   page_pool: Cleanup and rename page_pool functions.
> > 
> > Saeed Mahameed (2):
> >   page_pool: Add API to update numa node and flush page caches
> >   net/mlx5e: Rx, Update page pool numa node when changed
> > 
> > Tariq Toukan (3):
> >   net/mlx5e: RX, Remove RX page-cache
> >   net/mlx5e: RX, Manage RX pages only via page pool API
> >   net/mlx5e: RX, Internal DMA mapping in page_pool
> > 
> >  drivers/net/ethernet/mellanox/mlx5/core/en.h  |  18 +-
> >  .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |  12 +-
> >  .../net/ethernet/mellanox/mlx5/core/en_main.c |  19 +-
> >  .../net/ethernet/mellanox/mlx5/core/en_rx.c   | 128 ++--------
> >  .../ethernet/mellanox/mlx5/core/en_stats.c    |  39 ++--
> >  .../ethernet/mellanox/mlx5/core/en_stats.h    |  19 +-
> >  include/net/page_pool.h                       | 216 +++++++++-----
> > --
> > -
> >  net/core/page_pool.c                          | 221 +++++++++++---
> > --
> > --
> >  8 files changed, 319 insertions(+), 353 deletions(-)
> >