netdev - Re: [ovs-dev] [PATCH net-next v4 06/10] net: openvswitch: simplify the flow_hash

Open Source and information security mailing list archives

Message-ID: <CALDO+SZ8AR65E9qqxO6MvrRiJrwSy10uK0Ex=hjYBmyJL=2SXA@mail.gmail.com>
Date:   Fri, 18 Oct 2019 16:27:07 -0700
From:   William Tu <u9012063@...il.com>
To:     xiangxia.m.yue@...il.com
Cc:     Greg Rose <gvrose8192@...il.com>, pravin shelar <pshelar@....org>,
        "<dev@...nvswitch.org>" <dev@...nvswitch.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [ovs-dev] [PATCH net-next v4 06/10] net: openvswitch: simplify
 the flow_hash

On Wed, Oct 16, 2019 at 5:54 AM <xiangxia.m.yue@...il.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
>
> Simplify the code and remove the unnecessary BUILD_BUG_ON.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> Tested-by: Greg Rose <gvrose8192@...il.com>
> ---

LGTM
Acked-by: William Tu <u9012063@...il.com>

>  net/openvswitch/flow_table.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
> index a10d421..3e3d345 100644
> --- a/net/openvswitch/flow_table.c
> +++ b/net/openvswitch/flow_table.c
> @@ -432,13 +432,9 @@ int ovs_flow_tbl_flush(struct flow_table *flow_table)
>  static u32 flow_hash(const struct sw_flow_key *key,
>                      const struct sw_flow_key_range *range)
>  {
> -       int key_start = range->start;
> -       int key_end = range->end;
> -       const u32 *hash_key = (const u32 *)((const u8 *)key + key_start);
> -       int hash_u32s = (key_end - key_start) >> 2;
> -
> +       const u32 *hash_key = (const u32 *)((const u8 *)key + range->start);
>         /* Make sure number of hash bytes are multiple of u32. */
> -       BUILD_BUG_ON(sizeof(long) % sizeof(u32));
> +       int hash_u32s = range_n_bytes(range) >> 2;
>
>         return jhash2(hash_key, hash_u32s, 0);
>  }
> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> dev@...nvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives