netdev - Re: [PATCH net] net: usb: lan78xx: Connect PHY before registering MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018070623.mavdkhuo327qbszw@beryllium.lan>
Date:   Fri, 18 Oct 2019 09:06:23 +0200
From:   Daniel Wagner <dwagner@...e.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, wahrenst@....net
Subject: Re: [PATCH net] net: usb: lan78xx: Connect PHY before registering MAC

On Thu, Oct 17, 2019 at 09:29:26PM +0200, Andrew Lunn wrote:
> As soon as the netdev is registers, the kernel can start using the
> interface. If the driver connects the MAC to the PHY after the netdev
> is registered, there is a race condition where the interface can be
> opened without having the PHY connected.
> 
> Change the order to close this race condition.
> 
> Fixes: 92571a1aae40 ("lan78xx: Connect phy early")
> Reported-by: Daniel Wagner <dwagner@...e.de>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Tested-by: Daniel Wagner <dwagner@...e.de>

Thanks for the fix!
Daniel