netdev - Re: [PATCH] net/lib80211: scrubbing the buffer for key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e30e0dfb989efa4314070b7194097001230210b7.camel@sipsolutions.net>
Date:   Fri, 18 Oct 2019 10:43:19 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Kangjie Lu <kjlu@....edu>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/lib80211: scrubbing the buffer for key

On Thu, 2019-10-17 at 23:53 -0500, Kangjie Lu wrote:
> The "key" is not scrubbed. As what peer modules do, the fixes zeros
> out the key buffer.

Why do you think this is useful/necessary? Please always describe that
in the commit log.

FWIW, I'm convinced that it's not at necessary at all, looking at how
this is allocated ...

johannes