netdev - Re: [PATCH v14 1/5] fs/nsfs.c: added ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Oct 2019 11:24:45 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Carlos Neira <cneirabustos@...il.com>
Cc:     netdev@...r.kernel.org, yhs@...com, ebiederm@...ssion.com,
        brouer@...hat.com, bpf@...r.kernel.org
Subject: Re: [PATCH v14 1/5] fs/nsfs.c: added ns_match

On Thu, Oct 17, 2019 at 12:00:28PM -0300, Carlos Neira wrote:
> ns_match returns true if the namespace inode and dev_t matches the ones
> provided by the caller.
> 
> Signed-off-by: Carlos Neira <cneirabustos@...il.com>
> ---
>  fs/nsfs.c               | 8 ++++++++
>  include/linux/proc_ns.h | 2 ++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/fs/nsfs.c b/fs/nsfs.c
> index a0431642c6b5..256f6295d33d 100644
> --- a/fs/nsfs.c
> +++ b/fs/nsfs.c
> @@ -245,6 +245,14 @@ struct file *proc_ns_fget(int fd)
>  	return ERR_PTR(-EINVAL);
>  }
>  
> +/* Returns true if current namespace matches dev/ino.
> + */

The above could be a single line comment.
Perhaps using kdoc format would be appropriate here.

> +bool ns_match(const struct ns_common *ns, dev_t dev, ino_t ino)
> +{
> +	return ((ns->inum == ino) && (nsfs_mnt->mnt_sb->s_dev == dev));

The parentheses on the line above seem unnecessary.

> +}
> +
> +
>  static int nsfs_show_path(struct seq_file *seq, struct dentry *dentry)
>  {
>  	struct inode *inode = d_inode(dentry);
> diff --git a/include/linux/proc_ns.h b/include/linux/proc_ns.h
> index d31cb6215905..1da9f33489f3 100644
> --- a/include/linux/proc_ns.h
> +++ b/include/linux/proc_ns.h
> @@ -82,6 +82,8 @@ typedef struct ns_common *ns_get_path_helper_t(void *);
>  extern void *ns_get_path_cb(struct path *path, ns_get_path_helper_t ns_get_cb,
>  			    void *private_data);
>  
> +extern bool ns_match(const struct ns_common *ns, dev_t dev, ino_t ino);
> +
>  extern int ns_get_name(char *buf, size_t size, struct task_struct *task,
>  			const struct proc_ns_operations *ns_ops);
>  extern void nsfs_init(void);
> -- 
> 2.20.1
>