lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Oct 2019 11:56:40 +0100 From: Ben Dooks <ben.dooks@...ethink.co.uk> To: linux-kernel@...ts.codethink.co.uk Cc: Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ptp_pch: include ethernet driver for external functions On 18/10/2019 11:51, Ben Dooks (Codethink) wrote: > The driver uses a number of functions from the ethernet driver > so include the header to remove the following warnings from > sparse about undeclared functions: > > drivers/ptp/ptp_pch.c:182:5: warning: symbol 'pch_ch_control_read' was not declared. Should it be static? > drivers/ptp/ptp_pch.c:193:6: warning: symbol 'pch_ch_control_write' was not declared. Should it be static? > drivers/ptp/ptp_pch.c:201:5: warning: symbol 'pch_ch_event_read' was not declared. Should it be static? > drivers/ptp/ptp_pch.c:212:6: warning: symbol 'pch_ch_event_write' was not declared. Should it be static? > drivers/ptp/ptp_pch.c:220:5: warning: symbol 'pch_src_uuid_lo_read' was not declared. Should it be static? > drivers/ptp/ptp_pch.c:231:5: warning: symbol 'pch_src_uuid_hi_read' was not declared. Should it be static? > drivers/ptp/ptp_pch.c:242:5: warning: symbol 'pch_rx_snap_read' was not declared. Should it be static? > drivers/ptp/ptp_pch.c:259:5: warning: symbol 'pch_tx_snap_read' was not declared. Should it be static? > drivers/ptp/ptp_pch.c:300:5: warning: symbol 'pch_set_station_address' was not declared. Should it be static? > > Should we include the header file from the ethernet driver directly > or if not, where should the declarations go? > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk> > --- > Cc: Richard Cochran <richardcochran@...il.com> > Cc: netdev@...r.kernel.org > Cc: linux-kernel@...r.kernel.org > --- > drivers/ptp/ptp_pch.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c > index dcd6e00c8046..2bb1184b6359 100644 > --- a/drivers/ptp/ptp_pch.c > +++ b/drivers/ptp/ptp_pch.c > @@ -20,6 +20,8 @@ > #include <linux/ptp_clock_kernel.h> > #include <linux/slab.h> > > +#include <../net/ethernet/oki-semi/pch_gbe/pch_gbe.h> oops, missed saving the version with ../../drivers/net > + > #define STATION_ADDR_LEN 20 > #define PCI_DEVICE_ID_PCH_1588 0x8819 > #define IO_MEM_BAR 1 > -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html
Powered by blists - more mailing lists