netdev - Re: [PATCH] macb: propagate errors when getting optional clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191019.115919.1355675870258176623.davem@davemloft.net>
Date:   Sat, 19 Oct 2019 11:59:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     m.tretter@...gutronix.de
Cc:     nicolas.ferre@...rochip.com, netdev@...r.kernel.org
Subject: Re: [PATCH] macb: propagate errors when getting optional clocks

From: Michael Tretter <m.tretter@...gutronix.de>
Date: Fri, 18 Oct 2019 16:11:43 +0200

> The tx_clk, rx_clk, and tsu_clk are optional. Currently the macb driver
> marks clock as not available if it receives an error when trying to get
> a clock. This is wrong, because a clock controller might return
> -EPROBE_DEFER if a clock is not available, but will eventually become
> available.
> 
> In these cases, the driver would probe successfully but will never be
> able to adjust the clocks, because the clocks were not available during
> probe, but became available later.
> 
> For example, the clock controller for the ZynqMP is implemented in the
> PMU firmware and the clocks are only available after the firmware driver
> has been probed.
> 
> Use devm_clk_get_optional() in instead of devm_clk_get() to get the
> optional clock and propagate all errors to the calling function.
> 
> Signed-off-by: Michael Tretter <m.tretter@...gutronix.de>

Applied, thanks.