netdev - Re: [net 12/15] net/mlx5e: kTLS, Enhance TX resync flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018185128.0cc912f8@cakuba.netronome.com>
Date:   Fri, 18 Oct 2019 18:51:28 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net 12/15] net/mlx5e: kTLS, Enhance TX resync flow

On Fri, 18 Oct 2019 19:38:24 +0000, Saeed Mahameed wrote:
> From: Tariq Toukan <tariqt@...lanox.com>
> 
> Once the kTLS TX resync function is called, it used to return
> a binary value, for success or failure.
> 
> However, in case the TLS SKB is a retransmission of the connection
> handshake, it initiates the resync flow (as the tcp seq check holds),
> while regular packet handle is expected.
> 
> In this patch, we identify this case and skip the resync operation
> accordingly.
> 
> Counters:
> - Add a counter (tls_skip_no_sync_data) to monitor this.
> - Bump the dump counters up as they are used more frequently.
> - Add a missing counter descriptor declaration for tls_resync_bytes
>   in sq_stats_desc.
> 
> Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>

Could you document the new counter in tls-offload.rst?