netdev - Re: [net 11/15] net/mlx5e: kTLS, Save a copy of the crypto info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191020100821.01d4c712@cakuba.netronome.com>
Date:   Sun, 20 Oct 2019 10:08:21 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Tariq Toukan <tariqt@...lanox.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eran Ben Elisha <eranbe@...lanox.com>
Subject: Re: [net 11/15] net/mlx5e: kTLS, Save a copy of the crypto info

On Sun, 20 Oct 2019 07:46:00 +0000, Tariq Toukan wrote:
> On 10/19/2019 2:16 AM, Jakub Kicinski wrote:
> > On Fri, 18 Oct 2019 19:38:22 +0000, Saeed Mahameed wrote:  
> >> From: Tariq Toukan <tariqt@...lanox.com>
> >>
> >> Do not assume the crypto info is accessible during the
> >> connection lifetime. Save a copy of it in the private
> >> TX context.  
> > 
> > It should be around as long as the driver knows about the socket, no?
> 
> The crypto info instance passed to the driver (as parameter in 
> connection creation callback) might be modified/zeroed/reused, so the 
> driver is expected to save its own copy, not just the pointer.

Can you point to a code path where that happens today?