netdev - Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191020173104.GB3080@lunn.ch>
Date:   Sun, 20 Oct 2019 19:31:04 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param
 for ATU hash algorithm.

On Sun, Oct 20, 2019 at 08:02:46AM +0200, Jiri Pirko wrote:
> Sun, Oct 20, 2019 at 07:54:59AM CEST, jiri@...nulli.us wrote:
> >Sat, Oct 19, 2019 at 11:12:34PM CEST, andrew@...n.ch wrote:
> >>> Could you please follow the rest of the existing params?
> >>
> >>Why are params special? Devlink resources can and do have upper case
> >>characters. So we get into inconsistencies within devlink,
> >>particularly if there is a link between a parameter and a resources.
> >
> >Well, only for netdevsim. Spectrum*.c resources follow the same format.
> >I believe that the same format should apply on resources as well.
> >
> 
> Plus reporters, dpipes follow the same format too. I'm going to send
> patches to enforce the format there too.

Hi Jiri

I'm pretty much against this. This appears to be arbitrary. There is
no technical reason, other than most users so far have kept to lower
case. But in general, the kernel does not impose such restrictions.

Ethtool statistics are mixed case.
Interface names are mixed case.
/dev devices are mixed case.
Namespaces are mixed case.
All HWMON properties and names are mixed case.
Interrupt names are mixed case.
IIO names are mixed case.
etc.

Apart from the FAT filesystem, can you think of any places in the
kernel which enforce lower case? And if so, why does it impose lower
case?

       Andrew